Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

[Gregor Mi]

> On April 17, 2015, 7:31 a.m., Martin Gräßlin wrote:
> > I'm still not sure about the text for the message box: could you please add Thomas Pfeiffer from Usability team to the review to get him comment on it?
> 
> Gregor Mi wrote:
>     Sure. I'll add him.

I updated the text.

Message box without KWin:

```
Typically, the kill window method can be invoked with the global shortcut Ctrl+Alt+Esc.

The mouse cursor will then change into a deadly skull or some other pirate symbol. If you left-click on a window, the corresponding process will be killed - and unsaved data be lost.

Typically, with right-click you can abort.
```


Message box text with KWin:

```
The kill window method can be invoked with a global shortcut which is currently set to:

Ctrl+Alt+Esc

The mouse cursor will then change into a deadly skull or some other pirate symbol. If you left-click on a window, the corresponding process will be killed - and unsaved data be lost.

With right-click or the Esc key you can abort.
```


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79097
-----------------------------------------------------------


On April 17, 2015, 7:32 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122249/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 7:32 a.m.)
> 
> 
> Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas Pfeiffer.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> Current situation:
> The "End Process..." button has a tooltip which says "To target a specific window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is hardcoded.
> 
> New:
> Replace the "End Process..." button with a drop-down button and a action named "Kill a specific window..."
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 66899e577a03786d894423a8f1ce5b3aeed6de8a 
>   processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 
>   processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 
>   processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c 
> 
> Diff: https://git.reviewboard.kde.org/r/122249/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New End Process button with drop down arrow
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
> new submenu
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png
> new message box
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150417/c09bfc2a/attachment.htm>