Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

[Thomas Lübking]

> On April 16, 2015, 3:14 nachm., Martin Gräßlin wrote:
> > processui/ksysguardprocesslist.cpp, line 359
> > <https://git.reviewboard.kde.org/r/122249/diff/9/?file=360668#file360668line359>
> >
> >     You could know whether kwin is used - the window manager name is exported to the root window.
> >     
> >     Users might not know what "KWin" is.
> 
> Gregor Mi wrote:
>     I also would like that better. I tried
>     - QApplication::desktop()->window()->windowTitle();
>     - QApplication::desktop()->windowTitle();
>     
>     Any other hint on how access this information?
> 
> Thomas Lübking wrote:
>     http://api.kde.org/frameworks-api/frameworks5-apidocs/kwindowsystem/html/classNETRootInfo.html#ad6269ee8e82664340b1ac5dead86991f
> 
> Gregor Mi wrote:
>     Ah, thanks. I found that NETRootInfo(QX11Info::connection(), NET::WMAllProperties).wmName() works. Though I had expected that NET::WMName instead of NET::WMAllProperties should also work, no?

try NET::SupportingWMCheck|NET::WMName - not actually sure. Smells like a bug indeed.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/#review79059
-----------------------------------------------------------


On April 17, 2015, 7:32 vorm., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122249/
> -----------------------------------------------------------
> 
> (Updated April 17, 2015, 7:32 vorm.)
> 
> 
> Review request for KDE Base Apps, Martin Gräßlin, John Tapsell, and Thomas Pfeiffer.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> Current situation:
> The "End Process..." button has a tooltip which says "To target a specific window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is hardcoded.
> 
> New:
> Replace the "End Process..." button with a drop-down button and a action named "Kill a specific window..."
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 66899e577a03786d894423a8f1ce5b3aeed6de8a 
>   processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 
>   processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 
>   processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c 
> 
> Diff: https://git.reviewboard.kde.org/r/122249/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> New End Process button with drop down arrow
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
> new submenu
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/eeaecc88-20bc-46d6-9c65-50ba4a7c182a__submenu.png
> new message box
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/5565e806-bf16-4ef2-89f2-ac122bf3421c__messagebox.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150417/2982a762/attachment.htm>