Review Request 122987: Allow user to specify path to myspell dictionary files

Aleix Pol Gonzalez aleixpol at kde.org
Tue Apr 7 02:44:43 BST 2015



> On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote:
> > src/plugins/hunspell/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line9>
> >
> >     endif()
> 
> Eugene Shalygin wrote:
>     Ping?

He means you shouldn't put anything inside endif() parenthesis.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
-----------------------------------------------------------


On March 17, 2015, 2:09 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 2:09 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user define this path.
> 
> 
> Diffs
> -----
> 
>   src/plugins/hunspell/CMakeLists.txt 098fb49 
>   src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
>   src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
>   src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150407/54fab1a3/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


More information about the kde-core-devel mailing list