Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

[Andrius da Costa Ribas]

> On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
> > lib/konq/src/konq_historyentry.h, line 57
> > <https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57>
> >
> >     const ref, no?

before I try to fix the pending issues: what are we going to decide?

- Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
- Should it apply to MSVC-only or should it be ifdef-free?


- Andrius da Costa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
-----------------------------------------------------------


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121080/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Frameworks and kdewin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not available. Implement it instead.
> 
> 
> Diffs
> -----
> 
>   lib/konq/src/konq_historyentry.h de34d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/121080/diff/
> 
> 
> Testing
> -------
> 
> It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI).
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20150404/5623d7a3/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel