martin.klapetek at gmail.com
Tue Sep 30 10:28:17 BST 2014
On Tue, Sep 30, 2014 at 7:44 AM, Gilles Caulier <caulier.gilles at gmail.com>
> 2014-09-30 3:06 GMT+02:00 Vishesh Handa <me at vhanda.in>:
> > Hey Tobias
> > Some comments about the code -
> > 1. The code seems to be licensed under GPL. In order to make it into a
> > framework, it will need to be re-licensed. This library seems like an
> > candidate for becoming a framework.
> libkface have been writted in same way than libkipi, libkexiv2, and
> libkdcraw, already in KDEGraphics.
The thing is - if libkface is set to become a framework and be part of the
KDE Frameworks effort, it has to follow KDE Frameworks policies and rules.
One of those is that the code is licensed under LGPLv2.1+ (I think, someone
correct me if I'm wrong). So libkface would have to be relicensed.
Unfortunately same for the other listed libraries if they should become
frameworks. And we would most certainly welcome that ;)
> > 2. The copyright header seems to say "Part of the Digikam Project". You
> > want to change that.
> Idem here. libkface follow exactly the same way than libkipi,
> libkexiv2, libkdcraw.
Personally I see nothing wrong with the "Part of the Digikam Project"; if
that framework is being developed as part of Digikam project, then why not
(we still have many files with "this is part of kdelibs project" btw).
> > 4. The coding style uses seems a little unorthdox. Could you perhaps add
> > link to where one can know what style is being followed? Maybe this
> could go
> > in the README file.
> coding style follow instructions from digiKam project :
That's another policy of the Frameworks - we try to have a consistent
coding style all over Frameworks, that means that libkface would have to
start following the same style in order to be included in Frameworks.
Martin Klapetek | KDE Developer
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-core-devel