Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

[Christoph Feck]

> On Sept. 23, 2014, 9:04 p.m., Christoph Feck wrote:
> > No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes.
> > 
> > But right now, limiting to a hardcoded 20px value is a bug, that affects usability on HighDPI screens, and should be fixed.
> > 
> > Anything else will likely affect several places in KDE code, and could be discussed, but not specific to this bug.
> 
> Christoph Feck wrote:
>     Boris, did you request commit rights in the mean time? :)
> 
> Boris Egorov wrote:
>     Christoph, where can I do this?

https://techbase.kde.org/Contribute/Get_a_Contributor_Account


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120120/#review67317
-----------------------------------------------------------


On Sept. 28, 2014, 4:03 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120120/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 4:03 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 338883
>     https://bugs.kde.org/show_bug.cgi?id=338883
> 
> 
> Repository: kmenuedit
> 
> 
> Description
> -------
> 
> Remove code which restricts app icons to 20x20 pixels
> 
> 
> Diffs
> -----
> 
>   treeview.cpp 99165ca 
> 
> Diff: https://git.reviewboard.kde.org/r/120120/diff/
> 
> 
> Testing
> -------
> 
> Build app, run it.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140928/6271f0fd/attachment.htm>