Review Request 120376: drKonqi Fix Bug 337742 - Unable to send report: error code 410 from Bugzilla

[Frédéric Sheedy]

> On sep. 26, 2014, 11:54 matin, Ian Wadham wrote:
> > Hi Frédéric,
> > 
> > As announced on KDE Core devel, in http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks ago, I also am working on Dr Konqi.
> > 
> > I am about to publish a general patch, which is aimed at the present problem posed by the change to tokens in Bugzilla https://bugs.kde.org/show_bug.cgi?id=337742, but also intends to avoid such problems in future and to be forward-portable to KF5. My approach is to check the version number of the Bugzilla software and to switch to whichever security method is appropriate for that version: cookies, tokens or passwords-only.
> > 
> > Of course, my patch will implement tokens for the time being, but the idea is to switch automatically to passwords-only when the time comes, without any new release of KDE software being necessary. See http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService.html#LOGGING_IN in the documentation for Bugzilla 4.5.5 (the next version), as opposed to 4.4.5 (the current version). Bugzilla 4.5.5 allows tokens, but I believe they will be discontinued at some stage, though I cannot put my finger on where I have seen that discussion.
> > 
> > This should avoid users having to experience further bugs in Dr Konqi's connection to bugs.kde.org. My patch is also intended to be extendable, so that Dr Konqi can be updated and re-released, ahead of time, if any further feature change is announced by Bugzilla and could adversely affect Dr Konqi.

Great, good news! My patch was only a quick fix to what you are doing.


- Frédéric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120376/#review67481
-----------------------------------------------------------


On sep. 26, 2014, 4:21 matin, Frédéric Sheedy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120376/
> -----------------------------------------------------------
> 
> (Updated sep. 26, 2014, 4:21 matin)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Bugs: 337742
>     http://bugs.kde.org/show_bug.cgi?id=337742
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Bugzilla 4.4.5 now request token to create report.
> 
> 
> Diffs
> -----
> 
>   drkonqi/bugzillalib.h 570169b 
>   drkonqi/bugzillalib.cpp f74753c 
>   drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 46c95b6 
> 
> Diff: https://git.reviewboard.kde.org/r/120376/diff/
> 
> 
> Testing
> -------
> 
> Testing was done using crashtest program in drkonqui folder on https://bugstest.kde.org
> Create new bug report and add attachement works now.
> 
> 
> Thanks,
> 
> Frédéric Sheedy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140926/ca0a7260/attachment.htm>