Review Request 120287: [OS X] make kde-workspace build
Martin Gräßlin
mgraesslin at kde.org
Mon Sep 22 17:52:52 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67219
-----------------------------------------------------------
I assume you did not want to include those debug messages in qguiplatformplugin_kde.cpp?
CMakeLists.txt
<https://git.reviewboard.kde.org/r/120287/#comment46909>
just as a note: kinfocenter shold(tm) work on macos. at least there is a source file called info_osx.cpp
- Martin Gräßlin
On Sept. 22, 2014, 6:17 nachm., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 6:17 nachm.)
>
>
> Review request for KDE Software on Mac OS X and kde-workspace.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
> The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
> The oxygen style builds and looks good but shows some updating glitches due to compositing.
>
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.
>
>
> Diffs
> -----
>
> kcontrol/krdb/krdb.cpp 36fc99c
> kcontrol/style/CMakeLists.txt d832b20
> libs/CMakeLists.txt c0576fe
> qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 4f67cc5
> CMakeLists.txt 195f99c
> kcontrol/CMakeLists.txt fc666b1
>
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
>
>
> Testing
> -------
>
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).
>
>
> File Attachments
> ----------------
>
> copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140922/358749c9/attachment.htm>
More information about the kde-core-devel
mailing list