Review Request 120287: [OS X] make kde-workspace build

[Thomas Lübking]

> On Sept. 20, 2014, 12:29 nachm., Martin Gräßlin wrote:
> > kcontrol/CMakeLists.txt, lines 45-48
> > <https://git.reviewboard.kde.org/r/120287/diff/4/?file=313800#file313800line45>
> >
> >     so what's the point of the if now?
> >     
> >     We have:
> >     * Windows
> >     * Apple
> >     * Linux (by fontconfig)
> 
> Thomas Lübking wrote:
>     The actual check seems to be for Linux w/o fontconfig.
>     Likely possible but rare and strange setup.
> 
> René J.V. Bertin wrote:
>     Or APPLE without fontconfig, which might be a less rare setup. So I'd prefer to keep it like this and figure out in KF5 what the status of the fonts kcm is going to be.

I meant "why this check was originally introduced".
Someone then stood up and said "but fonconfig is not required on windows" - and not on apple either.

Martin then wondered "why is there a check itfp if it ultimaltey just checks 'if anything'" and me assumed the actual check is whether this is "NOT X11 OR FONTCONFIG_FOUND".


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67058
-----------------------------------------------------------


On Sept. 20, 2014, 12:52 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2014, 12:52 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
> The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
> The oxygen style builds and looks good but shows some updating glitches due to compositing.
> 
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 195f99c 
>   kcontrol/CMakeLists.txt fc666b1 
>   kcontrol/krdb/krdb.cpp 36fc99c 
>   kcontrol/style/CMakeLists.txt d832b20 
>   libs/CMakeLists.txt c0576fe 
> 
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).
> 
> 
> File Attachments
> ----------------
> 
> copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140920/34ebd3f3/attachment.htm>