Review Request 120120: kmenuedit: do not resize app icons (fixes #338883)

Christoph Feck christoph at maxiom.de
Tue Sep 9 21:09:45 BST 2014



> On Sept. 9, 2014, 8:02 p.m., Thomas L├╝bking wrote:
> > treeview.cpp, line 232
> > <https://git.reviewboard.kde.org/r/120120/diff/2/?file=310611#file310611line232>
> >
> >     Maybe rather try to limit to the font height instead?

Why? We use "Small" icon size next to text everywhere (buttons, menu items etc), so we expect the user to set a sane size (and the user expects the developer to respect that size).


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120120/#review66152
-----------------------------------------------------------


On Sept. 9, 2014, 6:37 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120120/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 6:37 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kmenuedit
> 
> 
> Description
> -------
> 
> Remove code which restricts app icons to 20x20 pixels
> 
> 
> Diffs
> -----
> 
>   treeview.cpp 99165ca 
> 
> Diff: https://git.reviewboard.kde.org/r/120120/diff/
> 
> 
> Testing
> -------
> 
> Build app, run it.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140909/c680f218/attachment.htm>


More information about the kde-core-devel mailing list