Review Request 120078: workaround QTBUG-40584

[Thomas Lübking]

> On Sept. 6, 2014, 12:46 nachm., Lukáš Tinkl wrote:
> > [ 22%] Building CXX object src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o                                                                                                                              
> > /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp: In member function ‘virtual void KMainWindow::applyMainWindowSettings(const KConfigGroup&)’:
> > /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:616:30: error: invalid use of incomplete type ‘class QWindow’
> >          resize(windowHandle()->size());
> >                               ^
> > In file included from /usr/include/qt5/QtWidgets/qwidget.h:45:0,
> >                  from /usr/include/qt5/QtWidgets/qmainwindow.h:45,
> >                  from /usr/include/qt5/QtWidgets/QMainWindow:1,
> >                  from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.h:34,
> >                  from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:27:
> > /usr/include/qt5/QtGui/qwindowdefs.h:56:7: error: forward declaration of ‘class QWindow’
> >  class QWindow;
> >        ^
> > In file included from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:890:0:
> > /home/ltinkl/git/plasma-next-setup-script/kxmlgui/build/src/moc_kmainwindow.cpp: In static member function ‘static void KMainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
> > /home/ltinkl/git/plasma-next-setup-script/kxmlgui/build/src/moc_kmainwindow.cpp:110:42: warning: ‘virtual void KMainWindow::showAboutApplication()’ is deprecated (declared at /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.h:604) [-Wdeprecated-declarations]
> >          case 5: _t->showAboutApplication(); break;
> >                                           ^
> > make[2]: *** [src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o] Error 1
> > make[1]: *** [src/CMakeFiles/KF5XmlGui.dir/all] Error 2
> > make: *** [all] Error 2
> 
> Thomas Lübking wrote:
>     gah... blast. you can't trust anybody anymore ;-)
>     sorry for the trouble.
> 
> Hrvoje Senjan wrote:
>     ah, forgot to mention in the report that it needs a QWindow include

I could simply at least have tried to compile the patch myself, before opening a review request =)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120078/#review65899
-----------------------------------------------------------


On Sept. 7, 2014, 11:02 vorm., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120078/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 11:02 vorm.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Bugs: 337353
>     https://bugs.kde.org/show_bug.cgi?id=337353
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> This
> a) ensures there's windowaHandle() to restore the size for
> b) works around a pending Qt bug by explicitly coyping the restored QWindow size to the QWidget size
> 
> also see https://git.reviewboard.kde.org/r/119594/
> 
> 
> Diffs
> -----
> 
>   src/kmainwindow.cpp e273a76 
> 
> Diff: https://git.reviewboard.kde.org/r/120078/diff/
> 
> 
> Testing
> -------
> 
> Hrvoje, see bug - not tested myself.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140907/86e5557e/attachment.htm>