Review Request 120077: Make sure that the time and date are editable when ntpdate is missing

[Mathias Tillman]

> On Sept. 6, 2014, 12:44 p.m., Lukáš Tinkl wrote:
> > Ship It!

I don't have a commit account, so if you deem the patch to be good enough, would you mind committing it for me?


- Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120077/#review65898
-----------------------------------------------------------


On Sept. 6, 2014, 9:38 a.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120077/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 9:38 a.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 337707
>     https://bugs.kde.org/show_bug.cgi?id=337707
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes a bug where if you enable automatic time synchronisation and for whatever reason remove ntpdate the time and date are not editable, and you can't disable the automatic synchronisation due to the missing binary. The only way around it currently is to install ntpdate again, go to date and time settings, disable automatic synchronisation and then finally remove ntpdate again.
> 
> It also makes the Servers list uneditable when ntpdate is missing, as well as it having the same tooltip as the checkbox.
> 
> 
> Diffs
> -----
> 
>   kcms/dateandtime/dtime.cpp f8e641b5e0863a3a122c75def2282e0eac5f8b1e 
> 
> Diff: https://git.reviewboard.kde.org/r/120077/diff/
> 
> 
> Testing
> -------
> 
> I have tried both with and without the ntpdate binary, and everything seems to work fine.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140907/bca19f28/attachment.htm>