Review Request 120080: Fixed error message not always appearing when failing to launch qdbusviewer

[Mathias Tillman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120080/
-----------------------------------------------------------

Review request for kde-workspace.


Bugs: 329094
    https://bugs.kde.org/show_bug.cgi?id=329094


Repository: khotkeys


Description
-------

The message that qdbusviewer failed to run doesn't always show. This happens when qtchooser is installed, but none of the KDE4 or KDE5 qdbusviewers are installed, causing qtchooser to end with an error code of 1 and printing an error that it can't find qdbusviewer. This patch works around that by using KProcess::execute which returns an error code as opposed to just a boolean.


Diffs
-----

  kcm_hotkeys/actions/dbus_action_widget.cpp 5c72762c60ff74850a6a549db75e759dc4aa86e7 

Diff: https://git.reviewboard.kde.org/r/120080/diff/


Testing
-------

Tried with qdbusviewer both properly installed and only using the qtchooser version.


Thanks,

Mathias Tillman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140906/19ec6f50/attachment.htm>