Review Request 120077: Make sure that the time and date are editable when ntpdate is missing

Mathias Tillman master.homer at gmail.com
Sat Sep 6 10:38:50 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120077/
-----------------------------------------------------------

Review request for kde-workspace.


Bugs: 337707
    https://bugs.kde.org/show_bug.cgi?id=337707


Repository: plasma-desktop


Description
-------

This fixes a bug where if you enable automatic time synchronisation and for whatever reason remove ntpdate the time and date are not editable, and you can't disable the automatic synchronisation due to the missing binary. The only way around it currently is to install ntpdate again, go to date and time settings, disable automatic synchronisation and then finally remove ntpdate again.

It also makes the Servers list uneditable when ntpdate is missing, as well as it having the same tooltip as the checkbox.


Diffs
-----

  kcms/dateandtime/dtime.cpp f8e641b5e0863a3a122c75def2282e0eac5f8b1e 

Diff: https://git.reviewboard.kde.org/r/120077/diff/


Testing
-------

I have tried both with and without the ntpdate binary, and everything seems to work fine.


Thanks,

Mathias Tillman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140906/21a069b5/attachment.htm>


More information about the kde-core-devel mailing list