Review Request 120839: Fix solid-device-automounter failing to automount unknown devices

[Christoph Feck]

> On Oct. 28, 2014, 8:09 p.m., Frank Schütte wrote:
> > I'm not familiar with the policies. I resolved the raised issues, so should I review my own request or is this something stupid?
> 
> Thomas Lübking wrote:
>     You're not supposed to approve your own patches (but if nobody ever feels in charge to approve it, "no veto" is good enough as well)
>     
>     This patch seems to partially revert 
>                       
>     commit c0681052c7d026507f799ea287fcaa3b4b9187ae
>     Author: Helio Chissini de Castro
>     Date:   Wed Sep 25 11:59:45 2013 -0300
>     
>         - Automount Unknown device option has wrong logic, and the only way to
>           make automount is by having a known device, turning the
>           AutomountUnknownDevices option useless. Detected by
>           george 'döt' tavares 'ät' sabiaexperience 'døt' com 'döt' br
>           
>     so I'd suggest ot attach at least Helio to get a comment on the intention.

The problem is that review board now lists this as "approved", so nobody will look at it.

I added Helio to list of reviewers, but I haven't seen anything of him lately.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120839/#review69337
-----------------------------------------------------------


On Oct. 28, 2014, 7:50 p.m., Frank Schütte wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120839/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 7:50 p.m.)
> 
> 
> Review request for kdelibs, Solid and Christoph Feck.
> 
> 
> Bugs: 243046 and 261376
>     http://bugs.kde.org/show_bug.cgi?id=243046
>     http://bugs.kde.org/show_bug.cgi?id=261376
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Hi Christoph,
> solid-device-automounter fails to automount unknown devices, even if it is checked,
> because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
> So this patch corrects the logic to at first evaluate shouldAutomountDevice.
> Inside this evaluation automountUnknownDevices is evaluated correctly.
> Please review this patch. Christoph Feck urged me to submit this patch.
> It took me quite a while to figure it out, though.
> Bye,
> Frank
> 
> 
> Diffs
> -----
> 
>   solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 
>   solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be 
> 
> Diff: https://git.reviewboard.kde.org/r/120839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frank Schütte
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141028/f7f4d49c/attachment.htm>