Review Request 120782: Allow stand-alone build of konqueror

[Dan Vrátil]

> On Oct. 24, 2014, 10:09 p.m., Christophe Giboudeaux wrote:
> > konqueror/CMakeLists.txt, line 32
> > <https://git.reviewboard.kde.org/r/120782/diff/1/?file=321968#file321968line32>
> >
> >     should be merged with line 22 or 24 if it's optional

It cannot, because KDED framework does not install into /usr/lib/cmake/KF5KDED, but /usr/lib/cmake/KDED for some reason, so ECM will fail to find it in the "KF5" component:

CMake Warning at /opt/kde-devel/share/ECM/find-modules/FindKF5.cmake:75 (find_package):                                                                                                                                            
  Could not find a package configuration file provided by "KF5KDED" with any
  of the following names:

    KF5KDEDConfig.cmake
    kf5kded-config.cmake
    
  Add the installation prefix of "KF5KDED" to CMAKE_PREFIX_PATH or set
  "KF5KDED_DIR" to a directory containing one of the above files.  If 
  "KF5KDED" provides a separate development package or SDK, be sure it has
  been installed.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120782/#review69117
-----------------------------------------------------------


On Oct. 24, 2014, 5:12 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120782/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 5:12 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This patch modifies konqueror/CMakeLists.txt so that konqueror can be built stand-alone (against installed libkonq).
> 
> 
> Diffs
> -----
> 
>   konqueror/CMakeLists.txt 37962ca 
>   konqueror/src/CMakeLists.txt 0f6767f 
>   konqueror/src/konqview.h e98ecba 
> 
> Diff: https://git.reviewboard.kde.org/r/120782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141028/30fe55c6/attachment.htm>