Review Request 115250: Try PASV mode when using Socks proxy

[Emil Sedgh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115250/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 9:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, Dawit Alemayehu and David Faure.


Repository: kdelibs


Description
-------

FTP has two modes: PASV and EPSV.
Not all server's support EPSV.

Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
That is because QHostAddress.protocol() returns -1 (unknown protocol) on KUrl("socks://localhost:3128").

So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.

This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.


Diffs
-----

  kioslave/ftp/ftp.cpp 5bb2e8d 

Diff: https://git.reviewboard.kde.org/r/115250/diff/


Testing
-------

Tested a server that lacks EPSV support with and without proxy.
Seems fine now.
Used to throw 'Internal Server error'.


Thanks,

Emil Sedgh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141027/c0c0ea05/attachment.htm>