Review Request 120210: kdoctools: style images more elegantly

Jack Ostroff ostroffjh at users.sourceforge.net
Wed Oct 22 01:48:02 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120210/#review68867
-----------------------------------------------------------

Ship it!


Ship It!

- Jack Ostroff


On Sept. 16, 2014, 1:15 a.m., T.C. Hollingsworth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120210/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 1:15 a.m.)
> 
> 
> Review request for Documentation, kdelibs, Luigi Toscano, and Jack Ostroff.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The ugly <hr> elements that used to surround DocBook <mediaobject> elements are removed, and replaced with CSS styling around <screenshot> and <informalfigure> elements only.  Plain <mediaobject> elements are now unstyled.
>     
> As discussed on the documentation team mailing list:
> http://lists.kde.org/?l=kde-doc-english&m=141019053410846&w=2
> 
> Filed originally against KDE/4.14 at the request of Luigi Toscano, will forward port to KF5/kdoctools also.
> 
> 
> Diffs
> -----
> 
>   doc/common/kde-default.css 24ef928 
>   doc/common/kde-docs.css db23b3e 
>   kdoctools/customization/kde-style.xsl 03e8bc9 
> 
> Diff: https://git.reviewboard.kde.org/r/120210/diff/
> 
> 
> Testing
> -------
> 
> Rerun meinproc4 against documentation; verified new style in konqueror and khelpcenter.
> 
> 
> Thanks,
> 
> T.C. Hollingsworth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141022/965930d9/attachment.htm>


More information about the kde-core-devel mailing list