Review Request 120676: Remove other kdelibs4support headers

Kevin Kofler kevin.kofler at chello.at
Tue Oct 21 14:20:09 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120676/#review68809
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Kofler


On Okt. 21, 2014, 2:53 vorm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120676/
> -----------------------------------------------------------
> 
> (Updated Okt. 21, 2014, 2:53 vorm.)
> 
> 
> Review request for kdelibs and Kevin Kofler.
> 
> 
> Repository: kompare
> 
> 
> Description
> -------
> 
> Remove other kdelibs4support headers
> 
> 
> Diffs
> -----
> 
>   komparenavtreepart/komparenavtreepart.cpp 7be64bb8aafec02cd6f9f4a61bf8f1f56f36d1ea 
>   komparepart/kompare_part.h 52bcc0b68cf3f665ae3ac09eebe8234044bd6c90 
>   komparepart/kompare_part.cpp 1521518f97603ee81c7f57cf4b721fe9bf18ae9b 
>   komparepart/komparesaveoptionswidget.h a10d972d4fc02a40e711874021ca381c93f8ba50 
>   kompareurldialog.h 875a645821daa30f65fb4f91e624e808a8ec6541 
>   libdialogpages/viewpage.cpp d49ef6e1d9aefc994180cfc46ec1df79ed326a3a 
>   main.cpp c89cedd69bb03df3888e1d6fd883e50850c5a06c 
> 
> Diff: https://git.reviewboard.kde.org/r/120676/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs, but I'm not sure if I got all of the kdelibs4support stuff since I have kdelibs headers in /usr/include here. I'll do further cleanup on a vm witohut kdelibs to check later on.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141021/7f1713bb/attachment.htm>


More information about the kde-core-devel mailing list