Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

Emmanuel Pescosta emmanuelpescosta099 at
Mon Oct 20 09:35:06 BST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 20, 2014, 10:35 a.m.)

Review request for kde-workspace and David Faure.


Fixed all mentioned problems

Repository: kio-extras


The filenamesearch ioslave lists all files/folders which match with the given search query.

Made some small adjustments:
* Ported the ioslave to Qt5/KF5
* Got rid of cleanup() and member variables
* Use lambda function validators instead of some weird if + assert things in searchDirectory/contentContainsPattern
* Immediately return when the search string is empty

Diffs (updated)

  CMakeLists.txt 5ceeaf1 
  filenamesearch/CMakeLists.txt PRE-CREATION 
  filenamesearch/filenamesearch.protocol PRE-CREATION 
  filenamesearch/kio_filenamesearch.h PRE-CREATION 
  filenamesearch/kio_filenamesearch.cpp PRE-CREATION 





Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list