Review Request 120630: Port from KTempDir to QTemporaryDir. Port from KUrl to QUrl.

Kevin Kofler kevin.kofler at chello.at
Fri Oct 17 19:09:38 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120630/#review68624
-----------------------------------------------------------


This one looks OK, but it changes the API, so it needs to go together with a matching Kompare change, doesn't it? (One more reason to do the Kompare parts in smaller chunks.)

- Kevin Kofler


On Okt. 17, 2014, 4:21 nachm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120630/
> -----------------------------------------------------------
> 
> (Updated Okt. 17, 2014, 4:21 nachm.)
> 
> 
> Review request for kdelibs and Kevin Kofler.
> 
> 
> Repository: libkomparediff2
> 
> 
> Description
> -------
> 
> Port from KTempDir to QTemporaryDir.
> 
> 
> Diffs
> -----
> 
>   kompare.h a8f3c5a71995c8416f9089f3c263f3691c9bfab5 
>   kompare.cpp e44b8a3dcf59a43de426b28c39412d4331949412 
> 
> Diff: https://git.reviewboard.kde.org/r/120630/diff/
> 
> 
> Testing
> -------
> 
> It builds and an updated kompare frameworks branch builds against it and runs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141017/70e4f586/attachment.htm>


More information about the kde-core-devel mailing list