Review Request 120287: [OS X] make kde-workspace build

[Martin Gräßlin]

> On Okt. 14, 2014, 6:38 nachm., Martin Gräßlin wrote:
> > I'm not understanding the changes in Plasma Netbook. Why do you want the Netbook shell on OSX while on the other side you disabled the desktop shell? AFAIK you cannot replace the shell of OSX, so having Netbook sounds pretty useless to me.
> 
> René J.V. Bertin wrote:
>     The point is not to have the shell, but to have access to plasmoids via plasma-windowed (or plasmoid-viewer if that application is still around and functional).
>     I've tried to explain that I have made a rather coarse selection (everything also included in MS Windows builds and that actually builds) rather than hand-picking only those components that would have a potential use. Doing so I indeed noticed that the desktop shell was excluded on Win32 but not the netbook shell. It didn't take me long to realise that the netbook shell is different enough from the usual desktop paradigm to be of interest to some users, to the extent that it can be made to function in a rooted, normal window of course.
>     I am of course open to feedback concerning the components that can be removed from the build without effect on components that do have a use.
>     
>     If I may think aloud a little bit:
>     Netbook or Desktop shells ... they open (fullscreen) windows in practice, right? If so, there could be an (academic?) interest in supporting them but with a regular window, allowing the user to set up a sort of MDI version of a desktop shell with "goodies" that would give a more coherent experience than running those same goodies individually on the OS X desktop. One could also think of a "shell" that only serves to host panels and widgets, not unlike Yahoo! Widgets (http://en.wikipedia.org/wiki/Yahoo!_Widgets)

> Netbook or Desktop shells ... they open (fullscreen) windows in practice, right?

no, they open "desktop" windows.

> If so, there could be an (academic?) interest in supporting them but with a regular window

no, that's what plasma-windowed is for. And I'm certainly not giving a +1 for the rather big changes to netbook shell if the only need is on an academic scale ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review68404
-----------------------------------------------------------


On Okt. 14, 2014, 6:06 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
> 
> (Updated Okt. 14, 2014, 6:06 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
> The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
> The oxygen style builds and looks good but shows some updating glitches due to compositing.
> 
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt df8a1f7 
>   kcontrol/CMakeLists.txt fc666b1 
>   kcontrol/krdb/krdb.cpp 36fc99c 
>   kcontrol/style/CMakeLists.txt d832b20 
>   libs/CMakeLists.txt c0576fe 
>   plasma/CMakeLists.txt 199dbb0 
>   plasma/generic/shells/plasma-windowed/plasmaapp.cpp dbdff47 
>   plasma/netbook/CMakeLists.txt 1eff685 
>   plasma/netbook/containments/CMakeLists.txt c96a688 
>   plasma/desktop/CMakeLists.txt 2de78dd 
>   plasma/desktop/applets/CMakeLists.txt 6f80cec 
>   plasma/generic/CMakeLists.txt cfaf14f 
>   plasma/generic/applets/CMakeLists.txt 2b888ee 
>   plasma/generic/dataengines/CMakeLists.txt d240683 
>   plasma/generic/runners/CMakeLists.txt 6831ac0 
>   plasma/generic/shells/plasma-windowed/CMakeLists.txt 86b7770 
>   plasma/generic/shells/plasma-windowed/Info.plist.template PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).
> 
> 
> File Attachments
> ----------------
> 
> copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141014/d2f08f70/attachment.htm>