Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon Oct 13 14:35:16 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120460/
-----------------------------------------------------------

(Updated Oct. 13, 2014, 3:35 p.m.)


Review request for kde-workspace and David Faure.


Repository: kio-extras


Description
-------

The filenamesearch ioslave lists all files/folders which match with the given search query.

Made some small adjustments:
* Ported the ioslave to Qt5/KF5
* Got rid of cleanup() and member variables
* Use lambda function validators instead of some weird if + assert things in searchDirectory/contentContainsPattern
* Immediately return when the search string is empty
 
https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/frameworks/show/dolphin/src/search


Diffs
-----

  filenamesearch/kio_filenamesearch.h PRE-CREATION 
  filenamesearch/kio_filenamesearch.cpp PRE-CREATION 
  CMakeLists.txt 2036392 
  filenamesearch/CMakeLists.txt PRE-CREATION 
  filenamesearch/filenamesearch.protocol PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120460/diff/


Testing
-------

Compiles.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141013/0a8c7cf4/attachment.htm>


More information about the kde-core-devel mailing list