Review Request 120543: Update FindPostgreSQL.cmake

Rolf Eike Beer kde at opensource.sf-tec.de
Fri Oct 10 08:08:19 BST 2014


Am 10.10.2014 08:46, schrieb Jaroslaw Staniek:
> On 10 October 2014 08:05, Rolf Eike Beer <kde at opensource.sf-tec.de> 
> wrote:
>>> Update FindPostgreSQL.cmake to make is useful. Based on cmake's (3.x) 
>>> one
>>> but further improved PostgreSQL_TYPE_INCLUDE_DIR lookup. The fix 
>>> comes from
>>> libpredicate (master).
>> 
>> I see no upstream bug report for this.
> 
> Would a bug report for Calligra master be OK for you?
> This is the only user of the PostgreSQL_TYPE_INCLUDE_DIR in entire KDE
> I the know about:
> 
> http://lxr.kde.org/search?_filestring=&_string=PostgreSQL_INCLUDE_DIR

You are not looking for PostgreSQL_TYPE_INCLUDE_DIR here, but for 
PostgreSQL_INCLUDE_DIR. And there seems to be no user of that at all 
inside KDE.

> I am sorry if I misunderstood.
> 
> Good thing that the file disappears in KF5, since cmake has pretty
> good own copy (not sufficient but I'll try to patch in the upstream).

CMake is the relevant upstream, Calligra is downstream (i.e. it uses our 
stuff).

Eike




More information about the kde-core-devel mailing list