Review Request 120535: attica: Add const to getter methods.

Sebastian K├╝gler sebas at kde.org
Thu Oct 9 12:25:20 BST 2014



> On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote:
> > According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ "changing the const/volatile qualifiers of the function" is BIC
> > 
> > Now the thing is if we allow BIC changes in frameworks like attica or not is for someone else to answer.
> 
> Jeremy Whiting wrote:
>     Yes, I saw that, the real question is if we allow BIC changes or not. Also I guess if we don't allow BIC changes in frameworks anymore we should change that page to not say BIC changes should all happen on Monday's anymore :)
> 
> Aleix Pol Gonzalez wrote:
>     Also you can add a TODO KF5 comment. And yes, fix the wiki... :/
> 
> Jeremy Whiting wrote:
>     Do you mean TODO KF6 ?

If it's released as part of Frameworks, we don't allow BIC changes.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120535/#review68095
-----------------------------------------------------------


On Oct. 8, 2014, 9:20 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120535/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:20 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Frederik Gladhorn.
> 
> 
> Repository: attica
> 
> 
> Description
> -------
> 
> Add const to getter methods.
> 
> 
> Diffs
> -----
> 
>   src/downloaddescription.h 08796c9283d1412386f6e096b981c3afa2b1f55e 
>   src/downloaddescription.cpp f76a1601a53e66b836623f4ac7a67ceeb543c1f0 
> 
> Diff: https://git.reviewboard.kde.org/r/120535/diff/
> 
> 
> Testing
> -------
> 
> This builds and an improved knewstuff (with const AtticaDescription &foo, bar) in foreach lines builds.
> 
> My only question about committing this is if it's allowed since it's a binary incompatible change. If it's not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141009/7df53587/attachment.htm>


More information about the kde-core-devel mailing list