Review Request 120535: attica: Add const to getter methods.

Jeremy Whiting jpwhiting at kde.org
Wed Oct 8 22:20:50 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120535/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 3:20 p.m.)


Review request for KDE Frameworks, kdelibs and Frederik Gladhorn.


Repository: attica


Description
-------

Add const to getter methods.


Diffs
-----

  src/downloaddescription.h 08796c9283d1412386f6e096b981c3afa2b1f55e 
  src/downloaddescription.cpp f76a1601a53e66b836623f4ac7a67ceeb543c1f0 

Diff: https://git.reviewboard.kde.org/r/120535/diff/


Testing
-------

This builds and an improved knewstuff (with const AtticaDescription &foo, bar) in foreach lines builds.

My only question about committing this is if it's allowed since it's a binary incompatible change. If it's not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141008/e66ef267/attachment.htm>


More information about the kde-core-devel mailing list