Review Request 120528: [OS X]: respect icon visibility preference in system tray menus

[René J.V. Bertin]

> On Oct. 8, 2014, 1:47 p.m., Christoph Feck wrote:
> > To get changes into Qt, you directly create the review requests on the qt-project.org site: http://qt-project.org/wiki/Gerrit-Introduction
> 
> Christoph Feck wrote:
>     Ignore that comment... :P

Ok.

Or rather, I'll jump on the occasion to ask if there's any benefit to creating them here. KDE's reviewboard has the (IMHO) big advantage of not requiring you to commit changes to your local working copy, making it much easier to have several requests out and once and update them where required.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120528/#review68076
-----------------------------------------------------------


On Oct. 8, 2014, 1:28 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120528/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 1:28 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Qt KDE.
> 
> 
> Repository: qt
> 
> 
> Description
> -------
> 
> Makes Qt4 respect the user's icon-in-menus preference in system tray menus.
> See https://bugreports.qt-project.org/browse/QTBUG-41348 and
> https://codereview.qt-project.org/#/c/96485/
> 
> 
> Diffs
> -----
> 
>   src/gui/util/qsystemtrayicon_mac.mm 07e3ea2 
> 
> Diff: https://git.reviewboard.kde.org/r/120528/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 and 10.9.4 with MacPort's qt4-mac (4.8.6) as well as in Qt 4 git/HEAD.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141008/01216fa6/attachment.htm>