Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

Søren Holm sgh at sgh.dk
Mon Oct 6 19:53:02 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120406/
-----------------------------------------------------------

(Updated okt. 6, 2014, 6:53 p.m.)


Review request for kde-workspace and John Tapsell.


Repository: kde-workspace


Description
-------

IO-wait is included in the cpu usage. This is wrong since IO-wait is a part of the idle time. This goes for both total combines CPU-usage and the per CPU usage.


Diffs
-----

  ksysguard/ksysguardd/Linux/stat.c 534a465 

Diff: https://git.reviewboard.kde.org/r/120406/diff/


Testing
-------

Fx. running a read from a slow USB-media like this will always end up showing 25% load on my system (I have 4 cores)

dd if=/dev/sdb of=/dev/null bs=1M 

This end up being around 0% with my patch.


Thanks,

Søren Holm

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141006/d00f0857/attachment.htm>


More information about the kde-core-devel mailing list