Review Request 120406: ksysguardd: Avoid including IO-wait in CPU load.

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120406/#review67978
-----------------------------------------------------------


as that is a change which might break "My Workflow"(TM) (expect a script which parses the output) I doubt it's a 4.11 material, but should rather go into a feature release. Though that's just my personal opinion and I'm not a contributor to ksysguard.

- Martin Gräßlin


On Sept. 28, 2014, 5:07 p.m., Søren Holm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120406/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 5:07 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> IO-wait is included in the cpu usage. This is wrong since IO-wait is a part of the idle time. This goes for both total combines CPU-usage and the per CPU usage.
> 
> 
> Diffs
> -----
> 
>   ksysguard/ksysguardd/Linux/stat.c 534a465 
> 
> Diff: https://git.reviewboard.kde.org/r/120406/diff/
> 
> 
> Testing
> -------
> 
> Fx. running a read from a slow USB-media like this will always end up showing 25% load on my system (I have 4 cores)
> 
> dd if=/dev/sdb of=/dev/null bs=1M 
> 
> This end up being around 0% with my patch.
> 
> 
> Thanks,
> 
> Søren Holm
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141006/ca10c8ab/attachment.htm>