Review Request 120154: Equal entries implies existing directory
David Faure
faure at kde.org
Sun Nov 23 16:35:52 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120154/#review70819
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Sept. 12, 2014, 7:25 a.m., Jan-Marek Glogowski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120154/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2014, 7:25 a.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Equal entries implies existing directory
>
>
> Diffs
> -----
>
> kioslave/file/file_unix.cpp 4734399c3cde8e4a025539d8350ff1b3fabe83ae
>
> Diff: https://git.reviewboard.kde.org/r/120154/diff/
>
>
> Testing
> -------
>
> Equal entries implies existing directory
>
> The equal file error should take precedence over the existing
> directory error, as this implies exist.
>
> This actually prevents a data loss on case-insensitive file systems
> like CIFS, where renaming a directory from 'Test' to 'test' actually
> removes the single directory (both have the same inode).
>
>
> Thanks,
>
> Jan-Marek Glogowski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141123/294068b4/attachment.htm>
More information about the kde-core-devel
mailing list