Review Request 121083: Replace manual export files with CMake's generate_export_header

Andrius da Costa Ribas andriusmao-Re5JQEeQqe8AvxtiuMwx3w at public.gmane.org
Fri Nov 21 22:47:24 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
-----------------------------------------------------------

(Updated Nov. 21, 2014, 10:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for kde-workspace and kdewin.


Repository: oxygen


Description
-------

These files currently use  

```
__attribute__((visibility("...")))
```

which doesn't work on MSVC.


Diffs
-----

  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 
  liboxygen/CMakeLists.txt 69b7bd2 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
-------

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141121/26874429/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-windows mailing list
Kde-windows-RoXCvvDuEio at public.gmane.org
https://mail.kde.org/mailman/listinfo/kde-windows


More information about the kde-core-devel mailing list