Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

Thomas L├╝bking thomas.luebking at gmail.com
Mon Nov 17 21:45:25 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
-----------------------------------------------------------



attica-kde/kdeplugin/kdeplatformdependent.cpp
<https://git.reviewboard.kde.org/r/121161/#comment49366>

    is
    
    KdePlatformDependent::~KdePlatformDependent()
    {
       if (QCoreApplication::closingDown())
          m_accessManager->setParent(nullptr);
    }
    
    sufficient?


- Thomas L├╝bking


On Nov. 17, 2014, 9:11 nachm., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121161/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 9:11 nachm.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Plugin unload order was making the attica_kde plugin crash on close,
> this works around it by leaking one AccessManager.
> 
> 
> Diffs
> -----
> 
>   attica-kde/kdeplugin/kdeplatformdependent.cpp 489c03b18b7bb940007ab51cb197105fbc25de9f 
> 
> Diff: https://git.reviewboard.kde.org/r/121161/diff/
> 
> 
> Testing
> -------
> 
> knewstuff tests no longer crash on close.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141117/de00ef46/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list