Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

[Milian Wolff]

> On Nov. 17, 2014, 3:26 p.m., Aleix Pol Gonzalez wrote:
> > Looks good to me. +1
> > 
> > Can you look into doing this in KF5 (ECM) as well?

It's not applicable since we don't define `_BSD_SOURCE` at all there. It might even work to just remove this in KDE4 as well, but I don't want to have to test this all... So this sounds like the safe way to go for me for this legacy code.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70516
-----------------------------------------------------------


On Nov. 17, 2014, 3:29 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121147/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 3:29 p.m.)
> 
> 
> Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure, and Matthias Klumpp.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This silences the following compile warnings with newer GCC versions:
> 
> warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindKDE4Internal.cmake 134d14f11706f5a19a9b5e069119add2ea498dde 
> 
> Diff: https://git.reviewboard.kde.org/r/121147/diff/
> 
> 
> Testing
> -------
> 
> warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 which did the same.
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141117/d5824640/attachment.htm>