Review Request 121092: Use QSslCertificate::fromDevice to load certs in KDE SSL Certificates dialog

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121092/
-----------------------------------------------------------

(Updated Nov. 17, 2014, 5:32 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Bugs: 333079
    http://bugs.kde.org/show_bug.cgi?id=333079


Repository: kdelibs


Description
-------

This patch changes the use of QSslCertificate::fromPath to QSslCertificate::fromDevice when importing certificates in the SSL certificate dialog. This change is necessary because QSslCertificate::fromPath in Qt4 does not seem to be able to read certs in DER format. This problem, whatever it was, seems to be have been resolved in Qt5.


Diffs
-----

  kio/kssl/kcm/cacertificatespage.cpp 0a269a3a3fff41ffcc93bfb639f891dbf9016d66 

Diff: https://git.reviewboard.kde.org/r/121092/diff/


Testing
-------

Attempt to import the cert in DER format outlined in the bug report. I have also attached a simple program that tests all the different ways one can load certs using QSslCertificate.


File Attachments
----------------

test program
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/10/797589bb-56fd-4ee0-a45a-4a9694db1e88__test_qsslcertificate_import.cpp


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141117/1d8d6810/attachment.htm>