Review Request 121083: Replace manual export files with CMake's generate_export_header

Andrius da Costa Ribas andriusmao at gmail.com
Sun Nov 9 14:23:22 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121083/
-----------------------------------------------------------

Review request for kde-workspace and kdewin.


Repository: oxygen


Description
-------

These files currently use  

```
__attribute__((visibility("...")))
```

which doesn't work on MSVC.


Diffs
-----

  liboxygen/CMakeLists.txt 69b7bd2 
  liboxygen/oxygen_config_export.h 02ea29d 
  liboxygen/oxygen_export.h b8877a0 

Diff: https://git.reviewboard.kde.org/r/121083/diff/


Testing
-------

Builds with msvc 2013 64bit


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20141109/5fc52c46/attachment.htm>


More information about the kde-core-devel mailing list