Review Request 112294: Implement multi-seat support in KDM

[Stefan Brüns]

> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote:
> > kdm/backend/client.c, line 1465
> > <https://git.reviewboard.kde.org/r/112294/diff/7/?file=274914#file274914line1465>
> >
> >     you forgot the free(envbuf).
> >     
> >     i don't like the interminglig with the other type of setting env vars.
> >     also, it's missing the pam ifdef.
> >     how about putting it right in front of line 1515?
> >     
> >     of course that means that hypothetically you also need to cover the !PAM case, which you would do exactly at this place.
> >     i'm not sure it makes sense to bother, tough - i don't suppose a system with systemd but without pam makes much sense?

systemd itself requires pam, so this is not an issue.

fixed the other issues


> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote:
> > kdm/backend/dm.c, line 1436
> > <https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1436>
> >
> >     "no matching unused"

"There is no unused or no matching unused dynamic display for %s" sounds strange IMHO


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review58442
-----------------------------------------------------------


On May 26, 2014, 12:06 a.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112294/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:06 a.m.)
> 
> 
> Review request for kde-workspace and Oswald Buddenhagen.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This patch implements dynamic multiseat in KDM. It follows the description in:
> http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/
> 
> In case systemd is no found at compile time, nothing changes. If logind is not running, nothing changes. If no additional seats have been configured (some Plugable USB-GPUs are automatically added as additional seats), nothing changes.
> 
> In case there are additional seats beyond seat0, a reserved display is promoted to a local static one (and demoted if the seat is removed) and a new X-Server/greeter is spawned.
> 
> The code has been tested extensively, with a combination of [Radeon dedicated GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and https://bugzilla.redhat.com/show_bug.cgi?id=975079
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 117b3a5 
>   kdm/ConfigureChecks.cmake b61fd90 
>   kdm/backend/CMakeLists.txt 25f383f 
>   kdm/backend/client.c a2d06c2 
>   kdm/backend/dm.h b2f8c61 
>   kdm/backend/dm.c 77a2ef7 
>   kdm/backend/dpylist.c b650c2f 
>   kdm/backend/resource.c 38a8c70 
>   kdm/backend/server.c d8dd6f3 
>   kdm/backend/session.c 0e7901c 
>   kdm/config-kdm.h.cmake 3e8912d 
>   kdm/kfrontend/kdm_config.c 368c8d1 
> 
> Diff: https://git.reviewboard.kde.org/r/112294/diff/
> 
> 
> Testing
> -------
> 
> Single seat system, several multiseat systems
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140529/950c8174/attachment.htm>