Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

[Tomáš Trnka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117044/
-----------------------------------------------------------

(Updated May 6, 2014, 8:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Repository: kdelibs


Description
-------

Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

Previously, all unmounted autofs mountpoints were always mounted
by krunner/plasma-desktop on startup, defeating the purpose of
automounting. Let's ignore the unmounted filesystems instead when
gathering free space stats, just like the "df" utility does.

Everything still gets mounted properly on first real access.

The change itself is pretty trivial and I would regard it as a bugfix
(and thus eligible for 4.13), but I'm posting it for review to see
what you kdelibs people think.


Diffs
-----

  kio/kfile/kdiskfreespaceinfo.cpp f11eb0998f0e718e9b366f8c26da30586bfa44ef 

Diff: https://git.reviewboard.kde.org/r/117044/diff/


Testing
-------

I'm using this patch on kdelibs since 4.11 and I have noted no problems
in connection with ~4 automounted filesystems.


Thanks,

Tomáš Trnka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140506/4c1494ae/attachment.htm>