Review Request 117174: Fix installing and removing desktop plasma theme packages.

[Sebastian Kügler]

> On March 31, 2014, 4:04 p.m., Sebastian Kügler wrote:
> > plasma/packagestructure.cpp, line 653
> > <https://git.reviewboard.kde.org/r/117174/diff/2/?file=258228#file258228line653>
> >
> >     { go on the next line (here and elsewhere)
> 
> Andrei Amuraritei wrote:
>     Sorry don't get what you mean here?

Yeah, I meant on the same line, so

while (...) {

Same for if (...) {

Sorry for causing confusion.


> On March 31, 2014, 4:04 p.m., Sebastian Kügler wrote:
> > plasma/packagestructure.cpp, line 659
> > <https://git.reviewboard.kde.org/r/117174/diff/2/?file=258228#file258228line659>
> >
> >     This is going to be funny if you have multiple packages in the path you're specifying here, it will rely on directory listing ordering then -- perhaps not what you want. If it's random anyway, why parse all, and not just pick the first one?
> 
> Andrei Amuraritei wrote:
>     Hi there, so this // Question: Would it be better to search just the first level dirs for metadata.desktop file?  would be yes then ?
>     Or do you mean just grab the first "Directory" found and search there ?

I've done something similar in Plasma Next, and there it tries to find a metadata.desktop file in the current directory, if that fails, it searches the subdirectories, but not recursively. In this case, we want to be a bit flexible, but not go overboard scanning whole file system structures just because a wrong path has been issued.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117174/#review54702
-----------------------------------------------------------


On March 30, 2014, 1:14 p.m., Andrei Amuraritei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117174/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 1:14 p.m.)
> 
> 
> Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian Monroe.
> 
> 
> Bugs: 149479
>     http://bugs.kde.org/show_bug.cgi?id=149479
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Even though the bug appears RESOLVED it is not.
> 
> Minor hack to packagestructure.cpp to search for the metadata.desktop file recursively. This helps with installing desktop themes and removing them.
> I have tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore SoftSand for example, it's metadata.desktop is not properly formatted. There are others too which are not formatted which I guess could be fixed by setting a new format standard, maybe even a check package script to check new uploads on kde-look.org.
> 
> 
> Diffs
> -----
> 
>   plasma/packagestructure.cpp 71148e1 
> 
> Diff: https://git.reviewboard.kde.org/r/117174/diff/
> 
> 
> Testing
> -------
> 
> Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some themes are broken so they won't work (not install).
> 
> 
> Thanks,
> 
> Andrei Amuraritei
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140331/5ab44839/attachment.htm>