Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

Andrei Amuraritei sirdeiu at bydeiu.net
Sun Mar 30 13:28:04 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117175/
-----------------------------------------------------------

(Updated March 30, 2014, 12:28 p.m.)


Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian Monroe, and Lamarque Souza.


Changes
-------

Attached a plain diff -u -p orig fixed patch file. Tried updating the diff in the review req. I get the diff is empty message.


Bugs: 306279 and 325028
    http://bugs.kde.org/show_bug.cgi?id=306279
    http://bugs.kde.org/show_bug.cgi?id=325028


Repository: kde-runtime


Description
-------

When installing a new .comic provider from GHNS, it doesn't appear in the installed list on the comic widget.
This fixes it.


Diffs
-----

  plasma/tools/plasmapkg/main.cpp 61492fe 

Diff: https://git.reviewboard.kde.org/r/117175/diff/


Testing
-------

Compile, add new comic widget, install new comic providers.


File Attachments (updated)
----------------

patch with diff
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/30/313c693a-4c1e-4def-9c8f-4ab949d01874__kde-runtime-diff.patch


Thanks,

Andrei Amuraritei

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140330/eff5687d/attachment.htm>


More information about the kde-core-devel mailing list