Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.
Lamarque Souza
lamarque at kde.org
Sun Mar 30 12:28:38 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117175/#review54586
-----------------------------------------------------------
By the way, there must be a "delete installer;" before the mentioned "return 1" line, otherwise we will have a memory leak.
- Lamarque Souza
On March 30, 2014, 3:47 a.m., Andrei Amuraritei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117175/
> -----------------------------------------------------------
>
> (Updated March 30, 2014, 3:47 a.m.)
>
>
> Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian Monroe, and Lamarque Souza.
>
>
> Bugs: 306279 and 325028
> http://bugs.kde.org/show_bug.cgi?id=306279
> http://bugs.kde.org/show_bug.cgi?id=325028
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> When installing a new .comic provider from GHNS, it doesn't appear in the installed list on the comic widget.
> This fixes it.
>
>
> Diffs
> -----
>
> plasma/tools/plasmapkg/main.cpp 61492fe
>
> Diff: https://git.reviewboard.kde.org/r/117175/diff/
>
>
> Testing
> -------
>
> Compile, add new comic widget, install new comic providers.
>
>
> Thanks,
>
> Andrei Amuraritei
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140330/e05c9494/attachment.htm>
More information about the kde-core-devel
mailing list