Review Request 117166: remove /MainApplication object from screenlocker greeter interface

Thomas Lübking thomas.luebking at gmail.com
Sat Mar 29 20:32:10 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117166/
-----------------------------------------------------------

Review request for kde-workspace, Martin Gräßlin and Kirill Elagin.


Repository: kde-workspace


Description
-------

Turned out it's possible to kquitapp the greeter w/o having to provide the desktop.
whatever is the final resolution to bug #314989 resp. review #117157, ignorantly exposing the /MainApplication object on this process is certainly a bug. (I considered turning it into a QApplication, but that would have turned a HUGE patch and also the KDebug interface might be a benefit)

As the issue exists since 4.10, i don't think it's necessary to press this into 4.11.8 (and break the "workaround" in bug #314989, which then can be reasonably resolved before 4.11.9)


Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 

Diff: https://git.reviewboard.kde.org/r/117166/diff/


Testing
-------

locked screen, checked dbus interface of the greeter - MainApplication is gone.


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140329/5472a3e7/attachment.htm>


More information about the kde-core-devel mailing list