Review Request 116602: fix setting "ssl_was_in_use" metadata
Commit Hook
null at kde.org
Thu Mar 27 06:19:53 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54262
-----------------------------------------------------------
This review has been submitted with commit cf1a7a6f521837792296386275e0e66f7a40e631 by Andrea Iacovitti to branch KDE/4.12.
- Commit Hook
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 9:43 p.m.)
>
>
> Review request for kdelibs and Dawit Alemayehu.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified this happen) using [] operator results in inserting a new item with key "ssl_in_use" and NullString value in incomingMetaData map and, as a consequence, a new item with key "ssl_was_in_use" and NullString value in outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using queryMetadata().
>
>
> Diffs
> -----
>
> kio/kio/job.cpp edc5fed
>
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea Iacovitti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140327/97004499/attachment.htm>
More information about the kde-core-devel
mailing list