Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

David Jarvie djarvie at kde.org
Fri Mar 21 15:10:56 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/
-----------------------------------------------------------

(Updated March 21, 2014, 3:10 p.m.)


Review request for kdelibs.


Changes
-------

Fix null pointer access.


Repository: kdelibs


Description
-------

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.


Diffs (updated)
-----

  kio/kio/kdbusservicestarter.cpp 90624fb 

Diff: https://git.reviewboard.kde.org/r/116951/diff/


Testing
-------

Tested this scenario, and it now returns the error string.


Thanks,

David Jarvie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140321/84a3ab57/attachment.htm>


More information about the kde-core-devel mailing list