Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116784/
-----------------------------------------------------------

(Updated March 20, 2014, 1:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, Andreas Hartmetz and David Faure.


Repository: kdelibs


Description
-------

The attached patch does the following:

- It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for invalidate dates. It does not. The result is an overflow which is interpreted in kio_http as a timestamp in the distant future which obviously is wrong. See https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also affects the timestamp variables used for cache management.

- It converts cache management timestamp variables to 64 bits so they can accomodates dates beyond Feb 7, 2106.


Diffs
-----

  kioslave/http/http.h dd85622 
  kioslave/http/http.cpp e4f1eba 

Diff: https://git.reviewboard.kde.org/r/116784/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140320/23b1a59d/attachment.htm>