Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests
David Faure
faure at kde.org
Thu Mar 13 22:43:30 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116783/#review52916
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On March 13, 2014, 10:15 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116783/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 10:15 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> I completely missed ftpFileExists issued a SIZE command to determine the existence of a file when addressing bug# 326292. See https://git.reviewboard.kde.org/r/116524/ review request. The attached patch addresses that oversight to insure renaming files work properly on the android ftp server listed in the bug report.
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.h cbcd096
> kioslave/ftp/ftp.cpp b9d90e6
>
> Diff: https://git.reviewboard.kde.org/r/116783/diff/
>
>
> Testing
> -------
>
> Rerun all the tests run for 116524.
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140313/1ac153d1/attachment.htm>
More information about the kde-core-devel
mailing list