Review Request 116523: Do not call ftpSendMimeType for empty files in Ftp::ftpGet

[Dawit Alemayehu]

> On March 12, 2014, 2:39 p.m., David Faure wrote:
> > Thanks.
> > 
> > I hope we don't get into the case of "Unknown Size" when the size is actually 0, though. That case would still be buggy, and I'm not sure how we could fix it.

Well I could think of one scenario where that could potentially happen. The FTP server does not respond correctly to the SIZE command and the size of the file we are trying to retrieve is actually 0, but I am sure that is a rare server like the one reported in the very old bug report #168011.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116523/#review52761
-----------------------------------------------------------


On March 12, 2014, 1:26 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116523/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 1:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 323491
>     http://bugs.kde.org/show_bug.cgi?id=323491
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch fixes a bug where copying empty files (size == 0) from an ftp server to any other remote server (sftp, ftp) results in an error message that states the file could not be opened.
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/ftp.cpp ddc6eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/116523/diff/
> 
> 
> Testing
> -------
> 
> Attempt to copy an empty file from any ftp server to a remote destination, e.g. sftp server.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140313/d55ae888/attachment.htm>