Review Request 116122: Do not add trailing slash on http DELETE requests
Commit Hook
null at kde.org
Sat Mar 8 21:42:37 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review52413
-----------------------------------------------------------
This review has been submitted with commit e90577d4903d2c1b7a35e4a18efe3544132fbb57 by Dawit Alemayehu to branch KDE/4.12.
- Commit Hook
On March 8, 2014, 5:08 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116122/
> -----------------------------------------------------------
>
> (Updated March 8, 2014, 5:08 p.m.)
>
>
> Review request for kdelibs, Andrea Iacovitti and David Faure.
>
>
> Bugs: 331295
> http://bugs.kde.org/show_bug.cgi?id=331295
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the "fix" is only applicable to webdav and the addition of the trailing slash is communicated to the client application.
>
>
> Diffs
> -----
>
> kio/kio/deletejob.cpp b0268ef
> kioslave/http/http.cpp b4d64d4
>
> Diff: https://git.reviewboard.kde.org/r/116122/diff/
>
>
> Testing
> -------
>
> For HTTP delete:
> http://greenbytes.de/tech/tc/httpredirects/t301methods.html
>
> For WebDAV delete:
> http://boonfaya.com/sites/webdavapps.com/#targets
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140308/71a66e93/attachment.htm>
More information about the kde-core-devel
mailing list