Review Request 116570: Ask user for confirmation before doing POST -> POST redirection in KIO

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116570/
-----------------------------------------------------------

Review request for kdelibs, Andrea Iacovitti and David Faure.


Repository: kdelibs


Description
-------

This patch is a companion to the recent POST->POST redirection implementation in KIO, https://git.reviewboard.kde.org/r/116017/. It prompts the user to approve the redirection as explicitly required in sections 10.3.[2|3] of RFC 2616:

   If the 301 status code is received in response to a request other
   than GET or HEAD, the user agent MUST NOT automatically redirect the
   request unless it can be confirmed by the user, since this might
   change the conditions under which the request was issued.

Please note that this patch only prompts the user for confirmation on POST->POST redirections. It can be expanded to include redirections for other requests such as PUT.

There is also an issue of whether this patch should be part of the 4.13 release? Since we are in a freeze and the patch has both message changes as well as a new API, I have simply marked it for inclusion in master branch, i.e. 4.14.


Diffs
-----

  kio/kio/job.cpp 50b4afb 
  kio/kio/jobuidelegate.h 17fd554 
  kio/kio/jobuidelegate.cpp 5aff330 

Diff: https://git.reviewboard.kde.org/r/116570/diff/


Testing
-------

http://greenbytes.de/tech/tc/httpredirects/t307methods.html


File Attachments
----------------

POST redirection confirm dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e77dd03e-cb37-49bb-8554-cca991c8c546__post_redirection_confirmation.png


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140307/a6a66044/attachment.htm>