Review Request 116122: Do not add trailing slash on http DELETE requests

[Andrea Iacovitti]

> On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote:
> > Still broken for webdav protocol (tested using konq/dolphin), can't delete file.
> > "isFile" is always false whether you try to delete a file or folder so a trailing slash is always added.
> 
> Dawit Alemayehu wrote:
>     Well it works for me. I could not delete a webdav folder before this patch and I can afterwards. Are you sure you killed all existing kio_http processes before you run tests with the patched version?

I'm pretty sure..
May it be that the behaviour depends on the type of webdav server being used?
I tested against apache 2.2 with mod_dav enabled and a very basic configuration just to be able to create and delete files and folders.
With or without this patch, using webdav protocol, a trailing slash is always added to the url (isFile == false) and i can successfully delete folders while i can't delete files.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review51879
-----------------------------------------------------------


On March 3, 2014, 3:50 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116122/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 3:50 p.m.)
> 
> 
> Review request for kdelibs, Andrea Iacovitti and David Faure.
> 
> 
> Bugs: 331295
>     http://bugs.kde.org/show_bug.cgi?id=331295
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the "fix" is only applicable to webdav and the addition of the trailing slash is communicated to the client application.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp 9eba5d1 
> 
> Diff: https://git.reviewboard.kde.org/r/116122/diff/
> 
> 
> Testing
> -------
> 
> For HTTP delete:
> http://greenbytes.de/tech/tc/httpredirects/t301methods.html
> 
> For WebDAV delete:
> http://boonfaya.com/sites/webdavapps.com/#targets
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140304/a184b958/attachment.htm>