Review Request 116600: depend upon CMake 2.8.12

Martin Gräßlin mgraesslin at kde.org
Tue Mar 4 16:26:46 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116600/#review51906
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On March 4, 2014, 5:25 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116600/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 5:25 p.m.)
> 
> 
> Review request for kde-workspace and Martin Gräßlin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> FindXCB requires cmake 2.8.12 and kde-workspace asks for 2.8.6 so this warning/error(?) is printed
> 
> CMake Warning (dev) at /opt/kf5/share/ECM/find-modules/FindXCB.cmake:64 (message):
>   Your project should require at least CMake 2.8.12 to use FindXCB.cmake
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 41923b6 
> 
> Diff: https://git.reviewboard.kde.org/r/116600/diff/
> 
> 
> Testing
> -------
> 
> works, warning is gone
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140304/a5cba1db/attachment.htm>


More information about the kde-core-devel mailing list